Add typescript-eslint to widgetv2 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
toddkao
changed the title
codingki
approved these changes
Aug 22, 2024
toddkao
commented
Aug 22, 2024
Comment on lines
+1
to
+21
| name: ESLint Widget v2 | ||
|
|
||
| on: | ||
| pull_request: | ||
| paths: | ||
| - 'packages/widget-v2/**' | ||
|
|
||
| jobs: | ||
| eslint: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v3 | ||
| - uses: actions/setup-node@v3 | ||
| with: | ||
| node-version: '18' | ||
| - name: Install dependencies | ||
| run: yarn install | ||
| working-directory: packages/widget-v2 | ||
| - name: Run ESLint | ||
| run: yarn lint | ||
| working-directory: packages/widget-v2 |
There was a problem hiding this comment.
@codingki how do you feel about us adding this? it'll cause builds that have errors when running yarn lint to be red
I just added it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add typescript-eslint to widgetv2
Don't allow unused imports/variables
Don't allow console.log
Error when hooks don't follow rules of hooks
Error when hooks have missing dependencies