Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ErrorPage variants #217

Merged
merged 13 commits into from
Sep 5, 2024
Merged

Add ErrorPage variants #217

merged 13 commits into from
Sep 5, 2024

Conversation

toddkao
Copy link
Collaborator

@toddkao toddkao commented Sep 4, 2024 •
edited
Loading

Add ErrorPage variants
Add useGetAssetDetails
Add ClientOperations type and getClientOperation() to convert from SkipClientOperation to ClientOperation
Rename WalletSelectorFlow as WalletSelectorModal

Pages._.ErrorPage.-.Auth.Failed.Storybook.-.4.September.2024.mp4

@vercel Vercel
Copy link

vercel bot commented Sep 4, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
widget-nextjs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 5, 2024 0:27am

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Sep 4, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a3dce91

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@toddkao toddkao marked this pull request as ready for review September 4, 2024 23:51
codingki
codingki approved these changes Sep 5, 2024
View reviewed changes
Copy link
Member

@codingki codingki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice refactor

@toddkao toddkao merged commit bd3582a into main Sep 5, 2024
6 checks passed
@toddkao toddkao deleted the FRE-934 branch September 5, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codingki codingki codingki approved these changes

@NotJeremyLiu NotJeremyLiu Awaiting requested review from NotJeremyLiu NotJeremyLiu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddkao @codingki