Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement user endpoint cache of 6 hours #614

Merged
merged 9 commits into from
Feb 17, 2025

Conversation

WebSpider
Copy link
Contributor

The data in the user endpoint rarely changes, yet we request it on every update.
This implements an internal cache of the user data, skipping the update if the timestamp is still valid.

@WebSpider WebSpider requested review from dvx76 and prvakt February 5, 2025 11:41
@WebSpider WebSpider added the chore Code maintenance label Feb 5, 2025
@WebSpider
Copy link
Contributor Author

This code will become active when skodaconnect/myskoda#349 is in effect, but does not depend on it. If there is no timestamp recorded, we will simply get the information.

@WebSpider WebSpider requested a review from dvx76 February 17, 2025 10:45
@WebSpider WebSpider merged commit 8ff8058 into skodaconnect:main Feb 17, 2025
3 checks passed
@WebSpider WebSpider deleted the cache-userinfo branch February 17, 2025 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Code maintenance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants