Force update if charging service event contains no data #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
WebSpider
requested changes
Feb 11, 2025
WebSpider
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case the charging service event does not contain data, there is chance that no charging data is updated while the car is charging (scenario described in #608). Even now the battery charge percentage sensor does not get "Undefined" state, it is not updated properly (basically it may appear that the battery charge percentage in the beginning of the charging is 0% and then at some point already 100%). There is a need to track the actual battery charge process.
The PR fixes the problem by doing explicit request for updating the charging status if the service event does not contain status data.
The PR removes the use of the ServiceEventData structure because it is not sent from myskoda library anymore for charging service events.