Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SUV Coupe BodyType #15

Merged
merged 1 commit into from
Sep 22, 2024
Merged

Add SUV Coupe BodyType #15

merged 1 commit into from
Sep 22, 2024

Conversation

dvx76
Copy link
Member

@dvx76 dvx76 commented Sep 22, 2024

@dvx76 dvx76 requested review from WebSpider and Prior99 September 22, 2024 11:14
Copy link
Contributor

@WebSpider WebSpider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, but i think we should test seperate vehicles, not all of them in one go.

Seperate vehicles at seperate configurations/software likely have different capabilities.

@dvx76
Copy link
Member Author

dvx76 commented Sep 22, 2024

Lgtm, but i think we should test seperate vehicles, not all of them in one go.

Seperate vehicles at seperate configurations/software likely have different capabilities.

I agree but this is the trace I got from skodaconnect/homeassistant-myskoda#18 so figured I might as well include it. As we get more traces from various vehicles and endpoints we can refine the tests.

@dvx76 dvx76 merged commit da93a9d into skodaconnect:main Sep 22, 2024
1 check passed
@dvx76 dvx76 deleted the enyaq-coupe branch September 22, 2024 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Installation problems with Skoda Enyaq Coupe RS starting with v1.2.5
2 participants