Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for mqtt charging-error message #338

Merged
merged 2 commits into from
Jan 21, 2025
Merged

Add support for mqtt charging-error message #338

merged 2 commits into from
Jan 21, 2025

Conversation

WebSpider
Copy link
Contributor

@WebSpider WebSpider commented Jan 20, 2025 •
edited
Loading

Fixes #333

@WebSpider WebSpider marked this pull request as ready for review January 20, 2025 09:39
@WebSpider WebSpider requested review from Prior99, dvx76 and prvakt and removed request for Prior99 January 20, 2025 09:39
@WebSpider WebSpider added the bug Something isn't working label Jan 20, 2025
prvakt
prvakt approved these changes Jan 20, 2025
View reviewed changes
Copy link
Collaborator

@prvakt prvakt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@WebSpider WebSpider merged commit fdeb1bf into skodaconnect:main Jan 21, 2025
1 of 2 checks passed
@WebSpider WebSpider deleted the mqtt-charging-error branch January 21, 2025 09:05
@fursov fursov mentioned this pull request Feb 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prvakt prvakt prvakt approved these changes

@dvx76 dvx76 Awaiting requested review from dvx76

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ServiceEvent does not handle events with unknown name (i.e. 'charging-error')
2 participants
@WebSpider @prvakt