Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

18 info and examples #20

Merged
merged 10 commits into from
Feb 15, 2024
Merged

18 info and examples #20

merged 10 commits into from
Feb 15, 2024

Conversation

sroertgen
Copy link
Contributor

No description provided.

@sroertgen
Add notice #18
c6c53cd
@sroertgen
Add tooltips for form fields #18
e0a80cd
@sroertgen
Shorten tooltip #18
7ebd89b
@sroertgen
Improve parsing for dataset #18
0702cc2 
If concepts have multiple topConcepts of inScheme entries, it was kind of arbitrary until now, what would be chosen as the dataset.
This is now improved by setting the dataset to the concept scheme id.
@sroertgen
Add example buttons with test reconciliation service urls
954bc9c
@sroertgen
Add info about number of uploaded entries #18
c28558d
@sroertgen
Use ejs template engine to pass variable to upload page #18
b4e191f
@sroertgen sroertgen linked an issue Feb 14, 2024 that may be closed by this pull request
Add more Info about uploaded vocabs and examples #18
Closed
@sroertgen
Copy link
Contributor Author

@Phu2: Please deploy this branch to our test system

@Phu2
Copy link
Contributor

Phu2 commented Feb 14, 2024 •
edited
Loading

Deployed https://reconcile-publish-test.skohub.io/

@Phu2 Phu2 removed their assignment Feb 14, 2024
@sroertgen sroertgen requested a review from acka47 February 14, 2024 14:41
@sroertgen
Copy link
Contributor Author

@acka47 We now have some example service manifest urls to copy and a link to the overview page of all vocabularies.

@acka47
Copy link
Member

acka47 commented Feb 14, 2024

This looks nice. One minor thing: Could you add a "copy to clipboard" icon to the buttons of the example vocabularies? Otherwise +1

@acka47 acka47 removed their assignment Feb 14, 2024
@sroertgen
Copy link
Contributor Author

@acka47 Icon added as well as a tooltip to indicate successfull copy.

@acka47
Copy link
Member

acka47 commented Feb 15, 2024

a tooltip to indicate successfull copy.

This is nice but it is shown – at least in my case – not near the mouse cursor bit many centimeters higher:

image

Could this be shown next to the mouse cursor position instead?

@acka47 acka47 removed their assignment Feb 15, 2024
acka47
acka47 approved these changes Feb 15, 2024
View reviewed changes
Copy link
Member

@acka47 acka47 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now everything works fine. Thanks! +1

@sroertgen sroertgen merged commit 69636c6 into main Feb 15, 2024
1 check passed
@sroertgen sroertgen deleted the 18-info-and-examples branch February 15, 2024 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acka47 acka47 acka47 approved these changes

Assignees

@sroertgen sroertgen

Labels
None yet
Projects
SkoHub
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add more Info about uploaded vocabs and examples
3 participants
@sroertgen @Phu2 @acka47