Fixes #1385: Log inter-inter connection failures only on pn condition… #1386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1386 +/- ##
=====================================
Coverage 77.7% 77.7%
=====================================
Files 247 247
Lines 64084 64100 +16
Branches 5905 5907 +2
=====================================
+ Hits 49804 49828 +24
+ Misses 11556 11549 -7
+ Partials 2724 2723 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
kgiusti
reviewed
Jan 16, 2024
| } else { | ||
| qd_format_string(conn_msg, sizeof(conn_msg), "[C%"PRIu64"] Connection to %s failed", | ||
| ctx->connection_id, config->host_port); | ||
| qd_format_string(conn_msg_1, sizeof(conn_msg_1), "Connection to %s failed", config->host_port); | ||
| } |
There was a problem hiding this comment.
Can you just add a comment here explaining that we're trying to filter out loading the logs with duplicate messages if the connection cannot come up? Include the github issue for extra points, thanks.
There was a problem hiding this comment.
Done !! thanks
kgiusti
approved these changes
Jan 16, 2024
…n pn condition description change
ganeshmurthy
force-pushed
the
CONNECTOR-LOGGING-1
branch
from
f7742bc to
16b32b6
Compare
ganeshmurthy
added a commit
that referenced
this pull request
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… description change