Refactor builder extensions using inline keyword

skydoves · Jan 23, 2021 · 7fb9760 · 7fb9760
1 parent aa981df
commit 7fb9760
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/needs/src/main/java/com/skydoves/needs/NeedsItemTheme.kt b/needs/src/main/java/com/skydoves/needs/NeedsItemTheme.kt
@@ -31,7 +31,7 @@ internal annotation class NeedsItemThemeDsl
 /** creates an instance of [NeedsItemTheme] by [NeedsItemTheme.Builder] using kotlin dsl. */
 @JvmSynthetic
 @NeedsItemThemeDsl
-fun needsItemTheme(context: Context, block: NeedsItemTheme.Builder.() -> Unit): NeedsItemTheme =
+inline fun needsItemTheme(context: Context, block: NeedsItemTheme.Builder.() -> Unit): NeedsItemTheme =
   NeedsItemTheme.Builder(context).apply(block).build()
 
 /** NeedsItemTheme is an attribute class for changing item theme easily. */

diff --git a/needs/src/main/java/com/skydoves/needs/NeedsTheme.kt b/needs/src/main/java/com/skydoves/needs/NeedsTheme.kt
@@ -31,7 +31,7 @@ internal annotation class NeedsThemeDsl
 /** creates an instance of [NeedsTheme] by [NeedsTheme.Builder] using kotlin dsl. */
 @JvmSynthetic
 @NeedsThemeDsl
-fun needsTheme(context: Context, block: NeedsTheme.Builder.() -> Unit): NeedsTheme =
+inline fun needsTheme(context: Context, block: NeedsTheme.Builder.() -> Unit): NeedsTheme =
   NeedsTheme.Builder(context).apply(block).build()
 
 /** NeedsTheme is an attribute class for changing [Needs] popup theme easily. */

diff --git a/needs/src/main/java/com/skydoves/needs/TextForm.kt b/needs/src/main/java/com/skydoves/needs/TextForm.kt
@@ -29,7 +29,7 @@ internal annotation class TextFormDsl
 /** creates an instance of [TextForm] from [TextForm.Builder] using kotlin dsl. */
 @TextFormDsl
 @JvmSynthetic
-fun textForm(block: TextForm.Builder.() -> Unit): TextForm =
+inline fun textForm(block: TextForm.Builder.() -> Unit): TextForm =
   TextForm.Builder().apply(block).build()
 
 /**
@@ -41,6 +41,8 @@ class TextForm(builder: Builder) {
 
   @Sp
   val textSize = builder.textSize
+
+  @ColorInt
   val textColor = builder.textColor
   val textStyle = builder.textStyle