Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

example of using all_resources: true wildcard channel scoped event trigger #31

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

filmaj
Copy link

@filmaj filmaj commented Apr 16, 2024

Mainly for demonstration purposes, as a new feature coming out in the next SDK version.

FYI CI will fail until this PR gets updated w/ the new SDK releases, once they are out.

@filmaj filmaj self-assigned this Apr 16, 2024
@filmaj filmaj marked this pull request as ready for review April 16, 2024 19:46
@misscoded
Copy link
Contributor

In making this change, did you test to see if this sample still works?

@filmaj
Copy link
Author

filmaj commented Apr 16, 2024

Sure did!

Not sure if we want to merge this as-is or not; @seratch brought up a good point that defaulting to all_resources: true may have negative monetary impact (e.g. a workspace with a million channels may now be possibly invoking millions of workflows from the all_resources:true event trigger)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants