Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] master from kitodo:master #268

Merged
merged 15 commits into from
Feb 20, 2024
Merged

[pull] master from kitodo:master #268

merged 15 commits into from
Feb 20, 2024

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 16, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

matthias-ronge and others added 7 commits January 25, 2024 15:10
The script contains a database version that is reached after applying a
few database migration steps. It is not clear which database version is
contained. The file was never updated as further migration steps were
added. It is unusable for creating a database that matches the
application version.
These files were used in 2016 to migrate the 1.11x CE version. They no
longer have anything to do with the current development of 3.x. They are
still available in the 2.x branch. Here, they are deleted because they
served their purpose in the past.
Catch Exceptions in indexing processes, log warning and continue
@pull pull bot added the ⤵️ pull label Feb 16, 2024
solth and others added 8 commits February 19, 2024 09:03
Add integration and unit tests for ImportService
…ting

Update location of chrome driver for testing
Updated used action from version 3 to version 4
* Create a base for the Kitodo script

* Add a button in the Kitodo Script Dialog

* Implement

* Add tests

* Fix and complete messages

* Improve readability

* Fix checkstyle

* Fix checkstyle

* Fix checkstyle

* Print meaningful exception

* Print meaningful exception manually

* Fix a control flow error

* Remove error wrapper

* Test more generically, and give better error message on failure

* Fixes a typo

* Fix progress not working

* Prevents tasks not being indexed

* Support test file arrangement before and after PR #5876

* Fix Javadoc

* Remove 'final' modifier from functions used in constructors

Since private methods cannot be meaningfully overridden because of their
visibility, declaring them final is redundant.

* Use Files.walk() with try-with-resources

* Invert if-condition

* Use Files.walk() with try-with-resource

* Invert if-condition

* Fix Javadoc

* Fix a typo

* Spell out abbreviated negations in English

* Remove duplicate class 'TreeDeleter'

* Fix indent

* Reformat try-with-resources statements, remove unnecessary ';'

* Rewrite childDepth() to make use of OptionalInt

* Fix checkstyle

* Rearrange function calls and checks

The order of execution of the underlying tasks depends on the order in
which they are found on the disk and is unpredictable. Reliable testing
is only possible after the end of this group of tasks.

* Remove support for test files before PR #5876

* Use 'ProcessTestUtils' for clean-up

* Remove database IDs from test
@pull pull bot merged commit 0e0dcf8 into slub:master Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants