Skip to content

Commit

Permalink
Fix assert in PulseAudio 17.0 caused by same device name in multiple …
Browse files Browse the repository at this point in the history
…ucm configs

Updated devices: oneplus-enchilada, oneplus-fajita and xiaomi-beryllium

PulseAudio 17.0 introduced a different mapping of ucm config to pulse profiles. \
The current profile caused an `Assertion 'dev == data->device'` error, which resulted in audio being broken on sdm845 devices.

The error seems to be caused by the `Mic` device having the same name in both HiFi.conf and VoiceCall.conf.

Renaming `Mic` to `Mic1` in HiFi.conf, running `alsaucm reload` and rebooting the phone fixed the audio issue.

Reference:
* [PulseAudio 17.0 release notes](https://www.freedesktop.org/wiki/Software/PulseAudio/Notes/17.0/)
* [PulseAudio !596 introducing new ucm mapping](https://gitlab.freedesktop.org/pulseaudio/pulseaudio/-/merge_requests/596)
  • Loading branch information
f-izzo committed Jun 18, 2024
1 parent 34a4ee2 commit aaa7889
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion ucm2/OnePlus/enchilada/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ SectionVerb {
}
}

SectionDevice."Mic" {
SectionDevice."Mic1" {
Comment "Bottom Microphone"

EnableSequence [
Expand Down
2 changes: 1 addition & 1 deletion ucm2/OnePlus/fajita/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@ SectionVerb {
}
}

SectionDevice."Mic" {
SectionDevice."Mic1" {
Comment "Bottom Microphone"

EnableSequence [
Expand Down
6 changes: 3 additions & 3 deletions ucm2/Xiaomi/beryllium/HiFi.conf
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ SectionVerb {
}
}

SectionDevice."Speaker" {
SectionDevice."Speaker1" {
Comment "Speakers Stereo Output"

EnableSequence [
Expand All @@ -64,7 +64,7 @@ SectionDevice."Speaker" {
}
}

SectionDevice."Earpiece" {
SectionDevice."Earpiece1" {
Comment "Earpiece Output"

EnableSequence [
Expand Down Expand Up @@ -103,7 +103,7 @@ SectionDevice."Headphones" {
}
}

SectionDevice."Mic" {
SectionDevice."Mic1" {
Comment "Phone Bottom Mic"

EnableSequence [
Expand Down

0 comments on commit aaa7889

Please sign in to comment.