-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document gauge adapter expected output formats #197
Conversation
2f6bbdc
to
0458975
Compare
Hi @raehik thanks for this, greatly appreciated. Just to set expectations, I fear I won't get to giving this any thought before the end of the year or early next year. Sorry |
@raehik thanks again, I am now looking at this and would like to add on a few other changes. Could you "allow edits from maintainers"? |
As a preview, with my changes, the docs would look like this: https://rebench.readthedocs.io/en/docs-reorg/extensions/ (In a just merged commit, I also changed the theme, the top navigation bar was often over the text, which wasn't great) |
This was strangely hard to troubleshoot, but looks like I can't because the fork is on a GitHub org (thread)... let me move this PR to a personal fork instead. |
Our you could just pull or cherry pick my change from the branch :) |
This one here: https://github.com/smarr/ReBench/commits/docs-reorg |
…tput and more details Signed-off-by: Stefan Marr <git@stefan-marr.de>
Good point! Done & removed draft tag. |
And merged. Thanks a lot! |
Related to #186 . Some gauge adapters are intended to be plug-and-play, supporting common benchmark formats.
PlainSecondsLog
andReBenchLog
are custom and deserve some detail on the output format they expect.