Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix newly added clippy warning #58

Merged
merged 2 commits into from
Dec 3, 2024
Merged

Fix newly added clippy warning #58

merged 2 commits into from
Dec 3, 2024

Conversation

taiki-e
Copy link

@taiki-e taiki-e commented Nov 29, 2024

Resolve Rust 1.83 new clippy warning.

```
error: unneeded `return` statement
  --> tf_rosrust/src/tf_individual_transform_chain.rs:66:22
   |
66 |             Ok(x) => return Ok(self.transform_chain.get(x).unwrap().clone()),
   |                      ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
   = note: `-D clippy::needless-return` implied by `-D warnings`
   = help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
   |
66 |             Ok(x) => Ok(self.transform_chain.get(x).unwrap().clone()),
   |                      ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
```
@taiki-e taiki-e requested a review from OTL November 29, 2024 09:46
@taiki-e taiki-e enabled auto-merge (rebase) November 29, 2024 09:47
@taiki-e taiki-e disabled auto-merge November 29, 2024 09:53
@taiki-e taiki-e enabled auto-merge (squash) November 29, 2024 09:53
@taiki-e taiki-e merged commit 715dc18 into main Dec 3, 2024
6 checks passed
@taiki-e taiki-e deleted the taiki-e/clippy branch December 3, 2024 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants