Merge pull request #132 from smsapi/uri-with-port

Uri with port

CHANGELOG.md

@@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file.
 
 The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/) and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
 
+## [Unreleased]
+### Added
+- service url scheme and host validation
+- service url with port support
+
+### Changed
+- PSR-18 HTTP client related exceptions namespace moved
+
 ## [3.0.10] - 2024-01-16
 ### Added
 - PHP-8.3 support

src/Curl/Exception/ClientException.php

@@ -4,27 +4,14 @@
 
 namespace Smsapi\Client\Curl\Exception;
 
-use Exception;
-use Psr\Http\Client\ClientExceptionInterface;
-use Psr\Http\Message\RequestInterface;
+use Smsapi\Client\Infrastructure\HttpClient\ClientException as HttpClientException;
 
 /**
  * @api
+ * @deprecated
+ * @see HttpClientException
  */
-class ClientException extends Exception implements ClientExceptionInterface
+class ClientException extends HttpClientException
 {
-    private $request;
 
-    public static function withRequest(string $message, RequestInterface $request): self
-    {
-        $exception = new self($message);
-        $exception->request = $request;
-
-        return $exception;
-    }
-
-    public function getRequest(): RequestInterface
-    {
-        return $this->request;
-    }
 }

src/Curl/Exception/NetworkException.php

@@ -4,12 +4,14 @@
 
 namespace Smsapi\Client\Curl\Exception;
 
-use Psr\Http\Client\NetworkExceptionInterface;
+use Smsapi\Client\Infrastructure\HttpClient\NetworkException as HttpClientNetworkException;
 
 /**
  * @api
+ * @deprecated
+ * @see HttpClientNetworkException
  */
-class NetworkException extends ClientException implements NetworkExceptionInterface
+class NetworkException extends HttpClientNetworkException
 {
 
 }

src/Curl/Exception/RequestException.php

@@ -4,12 +4,14 @@
 
 namespace Smsapi\Client\Curl\Exception;
 
-use Psr\Http\Client\RequestExceptionInterface;
+use Smsapi\Client\Infrastructure\HttpClient\RequestException as HttpClientRequestException;
 
 /**
  * @api
+ * @deprecated
+ * @see HttpClientRequestException
  */
-class RequestException extends ClientException implements RequestExceptionInterface
+class RequestException extends HttpClientRequestException
 {
 
 }

src/Curl/HttpClient.php

@@ -8,8 +8,8 @@
 use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
-use Smsapi\Client\Curl\Exception\NetworkException;
-use Smsapi\Client\Curl\Exception\RequestException;
+use Smsapi\Client\Infrastructure\HttpClient\NetworkException;
+use Smsapi\Client\Infrastructure\HttpClient\RequestException;
 
 /**
  * @internal
@@ -34,7 +34,13 @@ public function sendRequest(RequestInterface $request): ResponseInterface
 
     private function prepareRequestHttpClient(RequestInterface $request)
     {
-        $url = sprintf("%s://%s%s", $request->getUri()->getScheme(), $request->getUri()->getHost(), $request->getRequestTarget());
+        $url = strtr("{scheme}://{host}{port}{path}", [
+            '{scheme}' => $request->getUri()->getScheme(),
+            '{host}' => $request->getUri()->getHost(),
+            '{port}' => $request->getUri()->getPort() ? ':' . $request->getUri()->getPort() : '',
+            '{path}' => $request->getRequestTarget()
+        ]);
+
         $httpClient = curl_init($url);
 
         if ($httpClient === false) {

src/Infrastructure/HttpClient/ClientException.php

@@ -0,0 +1,30 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smsapi\Client\Infrastructure\HttpClient;
+
+use Exception;
+use Psr\Http\Client\ClientExceptionInterface;
+use Psr\Http\Message\RequestInterface;
+
+/**
+ * @api
+ */
+class ClientException extends Exception implements ClientExceptionInterface
+{
+    private $request;
+
+    public static function withRequest(string $message, RequestInterface $request): self
+    {
+        $exception = new static($message);
+        $exception->request = $request;
+
+        return $exception;
+    }
+
+    public function getRequest(): RequestInterface
+    {
+        return $this->request;
+    }
+}

src/Infrastructure/HttpClient/Decorator/BaseUriDecorator.php

@@ -7,6 +7,7 @@
 use Psr\Http\Client\ClientInterface;
 use Psr\Http\Message\RequestInterface;
 use Psr\Http\Message\ResponseInterface;
+use Smsapi\Client\Infrastructure\HttpClient\RequestException;
 
 /**
  * @internal
@@ -33,14 +34,20 @@ private function prependBaseUri(RequestInterface $request): RequestInterface
     {
         $uri = $request->getUri();
 
+        if (!filter_var($this->baseUri, FILTER_VALIDATE_URL)) {
+            throw RequestException::withRequest("Invalid Base URI", $request);
+        }
+
         $baseUriParts = parse_url($this->baseUri);
 
         $scheme = $baseUriParts['scheme'] ?? '';
         $host = $baseUriParts['host'] ?? '';
+        $port = $baseUriParts['port'] ?? null;
         $basePath = $baseUriParts['path'] ?? '';
         $basePath = rtrim($basePath, '/');
 
         $uri = $uri->withPath($basePath . '/' . $uri->getPath());
+        $uri = $uri->withPort($port);
         $uri = $uri->withHost($host);
         $uri = $uri->withScheme($scheme);
 

src/Infrastructure/HttpClient/NetworkException.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smsapi\Client\Infrastructure\HttpClient;
+
+use Psr\Http\Client\NetworkExceptionInterface;
+
+/**
+ * @api
+ */
+class NetworkException extends ClientException implements NetworkExceptionInterface
+{
+
+}

src/Infrastructure/HttpClient/RequestException.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smsapi\Client\Infrastructure\HttpClient;
+
+use Psr\Http\Client\RequestExceptionInterface;
+
+/**
+ * @api
+ */
+class RequestException extends ClientException implements RequestExceptionInterface
+{
+
+}

src/SmsapiClient.php

@@ -12,7 +12,7 @@
  */
 interface SmsapiClient extends LoggerAwareInterface
 {
-    const VERSION = '3.0.10';
+    const VERSION = 'Unreleased';
 
     public function smsapiPlService(string $apiToken): SmsapiPlService;
 

tests/Helper/HttpClient/HttpClientRequestSpy.php

@@ -0,0 +1,27 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Smsapi\Client\Tests\Helper\HttpClient;
+
+use GuzzleHttp\Psr7\Response;
+use Psr\Http\Client\ClientInterface;
+use Psr\Http\Message\RequestInterface;
+use Psr\Http\Message\ResponseInterface;
+
+class HttpClientRequestSpy implements ClientInterface
+{
+    private $lastSentRequest;
+
+    public function sendRequest(RequestInterface $request): ResponseInterface
+    {
+        $this->lastSentRequest = $request;
+
+        return new Response();
+    }
+
+    public function getLastSentRequest(): RequestInterface
+    {
+        return $this->lastSentRequest;
+    }
+}

tests/SmsapiClientIntegrationTestCase.php

@@ -27,10 +27,6 @@ public static function prepare()
 
         $apiUri = Config::get('API URI');
 
-        if (!filter_var($apiUri, FILTER_VALIDATE_URL)) {
-            throw new RuntimeException('Invalid API URI');
-        }
-
         $smsapiHttpClient = new SmsapiHttpClient();
 
         $serviceName = Config::get('Service name');