Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trim optional separating whitespace in client protocols #457

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

bryfox
Copy link
Contributor

@bryfox bryfox commented Dec 6, 2024

This trims optional whitespace when extracting the advertised protocols from the client request, which is required to later verify that the server's response matches one of the protocols.

Fixes #456

@daniel-abramov daniel-abramov merged commit b31e88f into snapview:master Dec 9, 2024
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Subprotocols should allow for optional whitespace
2 participants