Don't pass field value to ValidatorReport if validation fails #892
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
force-pushed
the
schema-violations-fix
branch
from
bd092bd to
76912a1
Compare
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
force-pushed
the
schema-violations-fix
branch
from
76912a1 to
7c1e880
Compare
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
added a commit
that referenced
this pull request
Apr 30, 2024
spenes
force-pushed
the
schema-violations-fix
branch
from
7c1e880 to
2dd6bd0
Compare
benjben
requested changes
Apr 30, 2024
...in/scala/com.snowplowanalytics.snowplow.enrich/common/utils/AtomicFieldValidationError.scala
Outdated
Show resolved
Hide resolved
...in/scala/com.snowplowanalytics.snowplow.enrich/common/utils/AtomicFieldValidationError.scala
Outdated
Show resolved
Hide resolved
...in/scala/com.snowplowanalytics.snowplow.enrich/common/utils/AtomicFieldValidationError.scala
Outdated
Show resolved
Hide resolved
...a/com.snowplowanalytics.snowplow.enrich/common/enrichments/AtomicFieldsLengthValidator.scala
Outdated
Show resolved
Hide resolved
...ommon/src/main/scala/com.snowplowanalytics.snowplow.enrich/common/utils/MapTransformer.scala
Outdated
Show resolved
Hide resolved
benjben
approved these changes
May 2, 2024
spenes
force-pushed
the
schema-violations-fix
branch
from
5cebac0 to
5d132ec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In 4.2.0, we've started to use
SchemaViolationsinstead ofEnrichmentFailureswith some errors. While doing this change, we've usedValidatorReportto wrap atomic field validation errors and we've passed field values as well toValidatorReport. However, field values shouldn't be passed toValidatorReport. This PR makes necessary changes to remove those values fromValidatorReport.