Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feat] 어드민 UI 구현 #104

Merged
merged 17 commits into from
Aug 7, 2024
Merged

[Feat] 어드민 UI 구현 #104

merged 17 commits into from
Aug 7, 2024

Conversation

jhj2713
Copy link
Member

@jhj2713 jhj2713 commented Aug 6, 2024

🖥️ Preview

2024-08-06.6.27.34.mov

close #103

✏️ 한 일

  • 추첨 이벤트 당첨자 추첨 화면 구현
  • 추첨 이벤트 당첨자 목록 화면 구현
  • 선착순 이벤트 응모자 목록 화면 구현

❗️ 발생한 이슈 (해결 방안)

❓ 논의가 필요한 사항

@jhj2713 jhj2713 added the feat 기능 구현 label Aug 6, 2024
@jhj2713 jhj2713 requested a review from sooyeoniya August 6, 2024 09:28
@jhj2713 jhj2713 self-assigned this Aug 6, 2024
Copy link

github-actions bot commented Aug 6, 2024

빌드를 성공했습니다! 🎉

Copy link
Member

@sooyeoniya sooyeoniya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

어드민 고생하셨어용 🥺
전체 코드에서 flowbite 가져와서 사용한 부분에 dark: 부분 제외해주시면 감사하겠습니다 :)

}, []);

return (
<>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

빈태그가 필요한 이유가 있을까용?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

필요없네용 삭제했습니다!! ef2759d

Comment on lines 16 to 24
<svg
className="w-4 h-4 text-gray-500 dark:text-gray-400"
aria-hidden="true"
xmlns="http://www.w3.org/2000/svg"
fill="currentColor"
viewBox="0 0 20 20"
>
<path d="M20 4a2 2 0 0 0-2-2h-2V1a1 1 0 0 0-2 0v1h-3V1a1 1 0 0 0-2 0v1H6V1a1 1 0 0 0-2 0v1H2a2 2 0 0 0-2 2v2h20V4ZM0 18a2 2 0 0 0 2 2h16a2 2 0 0 0 2-2V8H0v10Zm5-8h10a1 1 0 0 1 0 2H5a1 1 0 0 1 0-2Z" />
</svg>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

svg 태그를 따로 분리 안한 이유가 있을까용? 저거 dark: 부분 빼는게 좋을 것 같아요!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

따로 이유는 없었어서 분리했어요! 47a725b

Comment on lines 30 to 31
className="bg-gray-50 border border-gray-300 text-gray-900 text-sm rounded-lg focus:ring-blue-500 focus:border-blue-500 block w-full ps-10 p-2.5 dark:bg-gray-700 dark:border-gray-600 dark:placeholder-gray-400 dark:text-white dark:focus:ring-blue-500 dark:focus:border-blue-500"
placeholder="Select date"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기두 dark: 부분 사용 안 하는거면 빼도 좋을듯용 :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cde7770 삭제했습니당~!

Copy link

github-actions bot commented Aug 7, 2024

빌드를 성공했습니다! 🎉

@jhj2713 jhj2713 merged commit 6d68e8b into dev Aug 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feat 기능 구현
Projects
None yet
Development

Successfully merging this pull request may close these issues.

어드민 - 페이지 UI 구현
2 participants