Skip to content

Commit

Permalink
Get the correct number when checking suppression levels.
Browse files Browse the repository at this point in the history
  • Loading branch information
Hhyemin committed Sep 2, 2024
1 parent dafa7e8 commit 2e50b55
Showing 1 changed file with 11 additions and 4 deletions.
15 changes: 11 additions & 4 deletions src/suppression_study/experiments/CheckSuppressionLevels.py
Original file line number Diff line number Diff line change
Expand Up @@ -155,13 +155,12 @@ def run(self, repo_dirs):
is_useless_list = []
suppression_num = len(suppressions_in_latest_commit)
for i, line in enumerate(suppressions_in_latest_commit):
is_useless = False
line_splits = line.split(",")
file_path = line_splits[0]
line_num = int(line_splits[-1])
if line in useless_suppressions_in_latest_commit:
is_useless_list.append("useless")
else:
is_useless_list.append("")
is_useless = True

if i + 1 == suppression_num:
if file_path != pre_file_path:
Expand All @@ -170,16 +169,24 @@ def run(self, repo_dirs):
suppression_line_nums = []
is_useless_list = []
suppression_line_nums.append(line_num)
if is_useless:
is_useless_list.append("useless")
else:
is_useless_list.append("")
file_contain_suppression = join(repo_dir, file_path)
self.check_pylint_suppression_level(file_contain_suppression, suppression_line_nums, is_useless_list)
# here is the end point.
elif file_path != pre_file_path:
file_contain_suppression = join(repo_dir, pre_file_path)
self.check_pylint_suppression_level(file_contain_suppression, suppression_line_nums, is_useless_list)
suppression_line_nums = []
is_useless_list = []

suppression_line_nums.append(line_num)

if is_useless:
is_useless_list.append("useless")
else:
is_useless_list.append("")
pre_file_path = file_path

# repo level summary
Expand Down

0 comments on commit 2e50b55

Please sign in to comment.