[program] Account for the confidential transfer fee extension when re-allocating during configure account #172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joncinque
reviewed
Feb 7, 2025
Comment on lines
1252
to
1260
| let alice_account_keypair = Keypair::new(); | ||
| token | ||
| .create_auxiliary_token_account_with_extension_space( | ||
| &alice_account_keypair, | ||
| &alice.pubkey(), | ||
| vec![ExtensionType::ConfidentialTransferAccount], | ||
| ) | ||
| .await | ||
| .unwrap(); |
There was a problem hiding this comment.
Sorry if I'm being dense, but what is this for?
There was a problem hiding this comment.
Sorry, this is a little embarrassing, but I copied the test template from the test function in confidential_transfer.rs and this logic is a relic from there. This logic is actually not needed even in confidential_transfer.rs, so I removed this logic in both test files. Thanks for the catch.
Comment on lines
1321
to
1327
| let state = token.get_account_info(&alice_token_account).await.unwrap(); | ||
| let extension = state | ||
| .get_extension::<ConfidentialTransferAccount>() | ||
| .unwrap(); | ||
| assert!(bool::from(&extension.approved)); | ||
| assert!(bool::from(&extension.allow_confidential_credits)); | ||
| assert_eq!(extension.elgamal_pubkey, (*elgamal_keypair.pubkey()).into()); |
There was a problem hiding this comment.
Can you also check that the TransferFeeAmount and ConfidentialTransferFeeAmount extensions are present?
…` extensions are present
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When configuring a new confidential transfer account with
ConfigureAccountWithRegistry, it does not reallocate space for the confidential transfer with fee even when the mint is extended for transfer fees.More details in #129.
Summary of Changes
I added logic that checks whether the account is extended for transfer fees. If it does, then the logic accounts for the confidential transfer fee extension when calculating the needed space the account.
A test for configuring accounts with registry when there are fees was missing, so I added it.
Fixes #129.