Skip to content

Commit

Permalink
Merge pull request #39 from sorabito/develop
Browse files Browse the repository at this point in the history
AS-10897 added isMixpanelJqlIdentifier to use MixpanelJqlIdentifier as key for group by clause
  • Loading branch information
mumez authored Jun 5, 2020
2 parents d4926e1 + 8b74ece commit 7da3139
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 5 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
testing
isMixpanelJqlIdentifier
^ true
Original file line number Diff line number Diff line change
@@ -1,9 +1,10 @@
{
"instance" : {
"||" : "MasashiUmezawa 4/25/2019 14:22",
"createPredicate:rightOperand:" : "MasashiUmezawa 4/25/2019 13:51",
"isMixpanelJqlIdentifier" : "KazunoriUeda 6/2/2020 18:13",
"===" : "MasashiUmezawa 4/25/2019 12:26",
"tokensAccessorOn:" : "MasashiUmezawa 4/25/2019 11:31",
"||" : "MasashiUmezawa 4/25/2019 14:22",
">" : "MasashiUmezawa 4/25/2019 12:29",
"<" : "MasashiUmezawa 4/25/2019 12:29",
"<=" : "MasashiUmezawa 4/25/2019 12:29",
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
printing
tokensItem: item on: tokens
item isMixpanelJqlIdentifier ifTrue: [
^ tokens add: item asMixpanelJqlString
].
item isMixpanelJqlProperties ifTrue: [
^ tokens doubleQuoted: item asMixpanelJqlString
].
].
tokens add: item asMixpanelJqlKey
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"instance" : {
"tokensOn:" : "MasashiUmezawa 4/25/2019 15:26",
"tokensItem:on:" : "MasashiUmezawa 4/25/2019 15:31"
"tokensItem:on:" : "KazunoriUeda 6/2/2020 18:12"
},
"class" : { }
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
*Mixpanel-Jql-testing
isMixpanelJqlIdentifier
^ false
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"instance" : {
"asMixpanelJqlObject" : "KazunoriUeda 4/16/2019 17:27",
"asMixpanelJqlTokenString" : "KazunoriUeda 4/16/2019 17:28",
"isMixpanelJqlIdentifier" : "KazunoriUeda 6/2/2020 18:12",
"asMixpanelJqlString" : "KazunoriUeda 4/16/2019 17:27",
"asMixpanelJqlValue" : "MasashiUmezawa 4/24/2019 10:05",
"asMixpanelJqlKey" : "KazunoriUeda 4/16/2019 17:27",
Expand Down
4 changes: 2 additions & 2 deletions pharo-repository/Mixpanel-Jql.package/monticello.meta/version
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
(name 'Mixpanel-Jql-MasashiUmezawa.1574759422' message 'empty log message' id '45cf7ba5-525f-0d00-86b7-e2ee062aadb1' date '10 April 2020' time '11:54:25.550339 pm' author 'MasashiUmezawa' ancestors ((name 'Mixpanel-Jql-MasashiUmezawa.1574759421' message 'empty log message' id '237befa0-525f-0d00-86b6-5b82062aadb1' date '10 April 2020' time '11:53:09.24496 pm' author 'MasashiUmezawa' ancestors ((name 'Mixpanel-Jql-CompatibleUserName.1574759420' message 'Merge pull request #34 from sorabito/develop
(name 'Mixpanel-Jql-KazunoriUeda.1586737104' message 'empty log message' id '3d3d4b92-7863-0d00-8c1e-5bb2075b48b3' date '2 June 2020' time '6:49:58.868762 pm' author 'KazunoriUeda' ancestors ((name 'Mixpanel-Jql-KazunoriUeda.1586737103' message 'empty log message' id '8f729b8d-7863-0d00-8c1d-c989075b48b3' date '2 June 2020' time '6:48:40.239311 pm' author 'KazunoriUeda' ancestors ((name 'Mixpanel-Jql-KazunoriUeda.1586737102' message 'empty log message' id 'f9e42789-7863-0d00-8c1c-2c71075b48b3' date '2 June 2020' time '6:47:25.557155 pm' author 'KazunoriUeda' ancestors ((name 'Mixpanel-Jql-KazunoriUeda.1586737101' message 'empty log message' id 'bcff3486-7863-0d00-8c1b-1ef4075b48b3' date '2 June 2020' time '6:46:36.084777 pm' author 'KazunoriUeda' ancestors ((name 'Mixpanel-Jql-GitHub.1586737100' message 'Merge pull request #37 from sorabito/develop

PR for v0.1.12' id 'fb5828b0-bfb9-5303-8ea7-5aabb00d880f' date '26 November 2019' time '9:10:20 am' author 'CompatibleUserName' ancestors () stepChildren ())) stepChildren ())) stepChildren ())
Added MixpanelJqlRowExpression class >> undefined' id '8ee84615-3a87-52b9-89ea-460aee1097ab' date '13 April 2020' time '12:18:20 am' author 'GitHub' ancestors () stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())) stepChildren ())

0 comments on commit 7da3139

Please sign in to comment.