Update GitHub actions in basic CI example #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
v2 produces deprecation warnings regarding outdated Node.js.
The `actions-rs/toolchain` action is no longer maintained[1]. [1]: https://github.com/actions-rs/toolchain
|
Thanks! I think in my workflows I would still run rustup because Rust in the image can be a bit old. But it's probably not essential for an example file. |
sourcefrog
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
checkoutaction version to the latest (v4), since v2 produces warnings about deprecated Node.js version.Also, the use of
actions-rs/toolchainis removed as the action is no longer maintained. AFAICT,rustupis available in GitHub runners, but I am not sure if an extra step likerustup update stable && rustup default stableis necessary in the worklow? Please let me know if it should be added.