Specify version-qualified package names #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sourcefrog
force-pushed
the
117-package-name
branch
2 times, most recently
from
5b6d321 to
eb2b29f
Compare
sourcefrog
changed the title
(not used yet)
This should later let us better generate package ids. It is small so we just clone it, for now. Also, improve SourceFile::for_tests
This should later help us specify packages by including their path
Makes it less ambiguous for cases where there are multiple versions of the same package name in the dependency tree. Fixes #117
sourcefrog
force-pushed
the
117-package-name
branch
from
95251aa to
da26d15
Compare
sourcefrog
temporarily deployed
to
github-pages
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should disambiguate in trees that have multiple versions of the package that we want to test.
Fixes #117