feat(helm): add global settings for commonly used values #634
Conversation
jdpleiness
force-pushed
the
02-04-feat_helm_add_global_settings_for_commonly_used_values
branch
from
cde9617 to
bd175ff
Compare
| podSecurityContext: {} | ||
| # -- Global privileged mode settings that can be overridden per service | ||
| # Determines if pods/containers can run with elevated privileges | ||
| privileged: {} |
There was a problem hiding this comment.
this feels odd to have a global flag privileged and it's only applicable to selective daemonset
why not just disable them separately?
There was a problem hiding this comment.
@michaellzc in Red Hat's OpenShift Kubernetes platform, containers are only allowed to run as specific UIDs / GIDs, so the customer's OpenShift admin provides the UID / GID number to their site admin, who currently has to copy / paste this big blob onto all services in their Helm override file, which about doubles the length of the file and makes it difficult to read. This fact took us a couple months to get to the bottom of on a current Implementation Services engagement, so this config and a coming doc update will save future OpenShift customers much time.
There was a problem hiding this comment.
too clarify, I understand the use case of global PSC. This comment is specifically about the privileged flag.
jdpleiness
force-pushed
the
02-04-feat_helm_add_global_settings_for_commonly_used_values
branch
from
bd175ff to
79523da
Compare
jdpleiness
force-pushed
the
02-04-feat_helm_add_global_settings_for_commonly_used_values
branch
from
79523da to
8c750b5
Compare
REL-685: Add security context values to top sourcegraph values in Helm chart
Checklist
Test plan
TODO