Move several packages to internal/ #901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I also thought about moving |
|
We do import the gRPC definitions from the monorepo, so this would break some things right now. Personally, I think exporting the generated protos is convenient for building clients consuming the API anyways, so I'd prefer keeping |
|
Ah good point, I won't touch it. I guess I could pull out some internal helpers like |
stefanhengl
approved these changes
Jan 28, 2025
janhartman
approved these changes
Jan 28, 2025
| "go.uber.org/automaxprocs/maxprocs" | ||
|
|
||
| "github.com/sourcegraph/zoekt/internal/profiler" | ||
|
|
||
| "github.com/sourcegraph/zoekt/cmd" | ||
| "github.com/sourcegraph/zoekt/ctags" | ||
| "github.com/sourcegraph/zoekt/gitindex" | ||
| "github.com/sourcegraph/zoekt/internal/gitindex" |
There was a problem hiding this comment.
nit: it might be good to configure goimports or something similar to keep imports tidy :)
There was a problem hiding this comment.
Thanks, I hadn't checked "Optimize imports on save" for the zoekt repo.
keegancsmith
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the following packages to
internalto avoid exposing them in the API:ctagsdebugservergitindexshardstraceI checked public code search engines and saw no external references to these, besides zoekt forks. I did not move these packages:
build-> used in at least one external dependency rubygems-researchignore-> used by the sourcegraph repo to ignore files during unindexed searchBackground behind this PR: I became inspired to restructure the repo a bit and update the docs. I have a few more changes queued up.