-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fully revert windows support #909
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧹
Oh, no! I need that feature Please consider, maybe there is some way to keep zoekt running on windows? |
@Alligator-1 could you share what version/ commit of Zoekt you are running? An also the mechanism you use to run locally? I'll see what I can do to make sure things still work for you! |
Apparently, this is the version This version works fine, but periodically I watch for changes and either after enough time has passed, or if I notice any significant useful commits from my point of view - I upgrade, but now I'm afraid that I might stay on some old version if Windows support goes away.... (I'm not really a professional developer, but a hobbyist). How I use Zoekt:
that's it, nothing else... (by the way, I'll ask a question right away, I usually recreate the index again when I update the sources (WINE, for example). And it's a full recreate, I read but didn't fully understand - does zoekt allow to do partial index update over git? if yes - it would make the experience with it more convenient, it would be possible to update indexes more often). |
I see, you were using a version that built for windows, but that used direct file reads instead of mmap (which is considered too slow for serious production usage). I am hesitant to restore support, because it is untested, and not a configuration we run regularly. However, I'm really open to reconsidering this decision if we hear from more Windows users that find Zoekt useful. I'll keep an eye on this PR for comments or reactions.
You're correct, that's the default behavior. We do have an experimental feature called "delta" indexing" that computes what's changed in the repo, and only updates those files. If you use the |
So be it, if that's all it is? |
We added support for Windows in #535. We then partially reverted the change, specifically the parts related to mmap (#706). This was okay because we no longer build for Windows.
This PR fully removes support to avoid being in a partially-implemented state.