fix(i): Sort out invalid testing framework node indexing #3068
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
bug
shahzadlone
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3068 +/- ##
===========================================
+ Coverage 79.35% 79.36% +0.01%
===========================================
Files 345 345
Lines 26557 26557
===========================================
+ Hits 21074 21076 +2
+ Misses 3956 3955 -1
+ Partials 1527 1526 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 6 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
shahzadlone
force-pushed
the
fix/incorrect-node-index-http-sourcehub
branch
3 times, most recently
from
7b56f43 to
0e777fd
Compare
nasdf
approved these changes
Sep 25, 2024
and mark a todo
shahzadlone
force-pushed
the
fix/incorrect-node-index-http-sourcehub
branch
from
0e777fd to
6b9be21
Compare
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Oct 20, 2024
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Oct 20, 2024
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Oct 20, 2024
shahzadlone
added a commit
to shahzadlone/defradb
that referenced
this pull request
Oct 20, 2024
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
…rk#3068) ## Relevant issue(s) Resolves sourcenetwork#3065 ## Description The main bug was only visible on sourcehub acp using http, due to the identity being copied with the audience value of another node's host failing authentication (the bearer tokens should be unique using correct node's audience). The biggest issue was the way we use `getNodes` and `getNodeCollections`. I would be in favor of completely removing them as they are more troublesome than the utility they provide. - First commit documents the bug - Some utility functions were overwriting and producing the wrong node index - Forbidden bug happening on sourcehub<>http test run: https://github.com/sourcenetwork/defradb/actions/runs/10930293192/job/30342883535?pr=2907 ### Future: - Resolve import/export documentation and implementation if different (sourcenetwork#3067) - Should likely clean this test utils up and make helper methods to avoid code duplication (sourcenetwork#3069) - Likely should remove all usages of `getNodeCollections` (sourcenetwork#3069) - Likely should remove all usages of `getNodes` (sourcenetwork#3069) ## How has this been tested? - Very painfully haha, had to install Linux bare-metal to investigate the first bug (sourcehub doesn't build on wsl for me) that was only occurring on sourcehub acp using http, due to the identity being copied with the audience value of another node the way we use `getNodes` and `getNodeCollections`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3065
Description
The main bug was only visible on sourcehub acp using http, due to the identity being copied with the audience value of another node's host failing authentication (the bearer tokens should be unique using correct node's audience). The biggest issue was the way we use
getNodesandgetNodeCollections. I would be in favor of completely removing them as they are more troublesome than the utility they provide.Future:
getNodeCollections(Clean up test utils, make helpers to avoid code duplication and remove confusing util functions #3069)getNodes(Clean up test utils, make helpers to avoid code duplication and remove confusing util functions #3069)How has this been tested?
getNodesandgetNodeCollections