test(i): Fix the nodes ID/index bug in tests #3162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shahzadlone
added
bug
shahzadlone
force-pushed
the
lone/test/improve-get-nodes
branch
from
9ca479a to
fb558ab
Compare
shahzadlone
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3162 +/- ##
===========================================
- Coverage 78.10% 78.01% -0.10%
===========================================
Files 354 354
Lines 34660 34660
===========================================
- Hits 27071 27038 -33
- Misses 5972 5996 +24
- Partials 1617 1626 +9
Flags with carried forward coverage won't be shown. Click here to find out more. see 13 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
nasdf
approved these changes
Oct 21, 2024
| // greater than 0. For example if requesting a node with nodeID=2 then the resulting output will contain only | ||
| // one element (at index 0) caller might accidentally assume that this node belongs to node 0. Therefore, the | ||
| // caller should always use the returned IDs, instead of guessing the IDs based on node indexes. | ||
| func getNodesWithIDs(nodeID immutable.Option[int], nodes []clients.Client) ([]int, []clients.Client) { |
There was a problem hiding this comment.
thought: this could be a custom iterator https://pkg.go.dev/iter that returns nodeID and node.
There was a problem hiding this comment.
Can do so in future if others feel strongly for it.
ChrisBQu
pushed a commit
to ChrisBQu/defradb
that referenced
this pull request
Feb 21, 2025
## Relevant issue(s) Resolves sourcenetwork#3076 ## Description - Fix the `getNodes` bug - Fix the temporary duplications in some actions - Remove the `getNodesCollection`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issue(s)
Resolves #3076
Description
getNodesbuggetNodesCollection