Add hop proxy command #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iBotPeaches
requested review from
jyann,
jweberst,
erik-perri,
Vacoris,
frankspress,
charlesreffett,
Bankamah and
nemanjar7
erik-perri
previously approved these changes
Oct 18, 2024
Bankamah
previously approved these changes
Oct 18, 2024
jweberst
previously approved these changes
Oct 18, 2024
nemanjar7
previously approved these changes
Oct 18, 2024
Vacoris
approved these changes
Oct 18, 2024
MOFFROUGH
approved these changes
Oct 18, 2024
jyann
previously approved these changes
Oct 18, 2024
…fined in VIRTUAL_HOST
Jasonej
dismissed stale reviews from jyann, nemanjar7, jweberst, Bankamah, and erik-perri
via
f5ba331
NilsDelaguardia
approved these changes
Oct 23, 2024
erik-perri
approved these changes
Oct 23, 2024
iBotPeaches
approved these changes
Oct 23, 2024
jweberst
approved these changes
Oct 31, 2024
Bankamah
approved these changes
Oct 31, 2024
jyann
reviewed
Oct 31, 2024
| exit 1 | ||
| elif [ "${#HOST_OPTIONS[@]}" -gt "1" ]; then | ||
| PS3="Select a Proxy URL (or quit to exit): " |
There was a problem hiding this comment.
Wording threw me off a little. "or type quit to exit" might be a little more clear
jyann
approved these changes
Oct 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the
hop proxycommand.Running
hop proxyin the root of a project will:--local-port)docker-compose.ymlordocker/docker-compose.ymlfor the first entry ofVIRTUAL_HOSTand use it as the local domain (override via--local-domain)docker-compose.override.ymlordocker/docker-compose.override.ymlfor the first entry ofVIRTUAL_HOSTthat does not match the local domain (respecting override if provided) and use it as the proxy domain (override via--proxy-domain)--proxy-port)