Merge pull request #8 from sourcetoad/wake-up

Code Style & Tests

.github/workflows/main.yml

@@ -0,0 +1,59 @@
+name: main
+on:
+  push:
+jobs:
+  tests:
+    runs-on: ubuntu-latest
+    strategy:
+      fail-fast: true
+      matrix:
+        php: [7.2, 7.3, 7.4]
+        stability: [prefer-lowest, prefer-stable]
+    name: PHP ${{ matrix.php }} - ${{ matrix.stability }}
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+
+      - name: Cache dependencies
+        uses: actions/cache@v1
+        with:
+          path: ~/.composer/cache/files
+          key: dependencies-php-${{ matrix.php }}-composer-${{ hashFiles('composer.json') }}
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ matrix.php }}
+          extensions: dom, curl, libxml, mbstring, zip, pcntl, gd, soap
+          coverage: none
+
+      - name: Install dependencies
+        run: composer update --${{ matrix.stability }} --prefer-dist --no-interaction --no-suggest
+
+      - name: Execute tests
+        run: vendor/bin/phpunit --verbose
+  code_styles:
+    runs-on: ubuntu-latest
+    name: Code Style
+    steps:
+      - name: Checkout
+        uses: actions/checkout@v2
+
+      - name: Cache dependencies
+        uses: actions/cache@v1
+        with:
+          path: ~/.composer/cache/files
+          key: dependencies-php-composer-${{ hashFiles('composer.json') }}
+
+      - name: Setup PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: '7.2'
+          coverage: none
+
+      - name: Install dependencies
+        run: composer install --no-suggest --prefer-dist -n -o
+
+      - name: Run style check
+        id: style_check
+        run: vendor/bin/phpcs

composer.json

@@ -18,10 +18,11 @@
         "php": ">=7.2.0",
         "ext-soap": "*",
         "ext-simplexml": "*",
-        "illuminate/support": "^6.0"
+        "illuminate/support": "^6.0|^7.0"
     },
     "require-dev": {
-        "orchestra/testbench": "^4.0"
+        "orchestra/testbench": "^3.8|^4.0|^5.0",
+        "squizlabs/php_codesniffer": "^3.5"
     },
     "autoload": {
         "psr-4": {

phpcs.xml

@@ -0,0 +1,9 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<ruleset name="PHP_CodeSniffer">
+    <file>./src</file>
+    <file>./tests</file>
+
+    <exclude-pattern>*/vendor/*</exclude-pattern>
+
+    <rule ref="PSR2" />
+</ruleset>

src/SoapyCurtain.php

@@ -113,7 +113,7 @@ public function setCache(int $cache): self
         $allowed = [WSDL_CACHE_NONE, WSDL_CACHE_DISK, WSDL_CACHE_MEMORY, WSDL_CACHE_BOTH];
 
         if (! in_array($cache, $allowed)) {
-            throw new \InvalidArgumentException('Cache value passed (' . $allowed . ') is not valid. Allowed (WSDL_CACHE_*)');
+            throw new \InvalidArgumentException('Cache value passed (' . $allowed . ') is not valid.');
         }
 
         $this->cache = $cache;
@@ -154,7 +154,7 @@ public function setLocation(string $location): self
 
     public function addTypeMapViaClassName(string $namespace, string $item, string $itemClass)
     {
-        $function = function(string $xml) use ($itemClass) {
+        $function = function (string $xml) use ($itemClass) {
             $object = simplexml_load_string($xml);
             return new $itemClass($object);
         };

src/SoapyServiceProvider.php

@@ -14,7 +14,7 @@ public function boot()
 
     public function register()
     {
-        $this->app->singleton(SoapyTub::class, function() {
+        $this->app->singleton(SoapyTub::class, function () {
             return new SoapyTub();
         });
     }