Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: [#6825]Update old packages #571

Closed
wants to merge 3 commits into from
Closed

fix: [#6825]Update old packages #571

wants to merge 3 commits into from

Conversation

JhontSouth
Copy link

@JhontSouth JhontSouth commented Jul 25, 2024 •
edited
Loading

Addresses # 6825
#minor

Description

This PR upgrades old packages that don't have conflicts with BotBuilder in their latest versions.

Specific Changes

  • Updated the following packages:
    • AdaptiveCards
    • Azure.Storage.Blobs
    • Azure.Storage.Queues
    • BenchmarkDotNet
    • coverlet.collector
    • coverlet.msbuild
    • JsonPath.Net
    • Microsoft.ApplicationInsights
    • Microsoft.ApplicationInsights.AspNetCore
    • Microsoft.ApplicationInsights.DependencyCollector
    • Microsoft.ApplicationInsights.PerfCounterCollector
    • Microsoft.ApplicationInsights.TraceListener
    • Microsoft.ApplicationInsights.Web
    • Microsoft.ApplicationInsights.WindowsServer
    • Microsoft.ApplicationInsights.WindowsServer.TelemetryChannel
    • Microsoft.AspNet.WebApi
    • Microsoft.AspNetCore.Hosting.Abstractions
    • Microsoft.AspNetCore.Http
    • Microsoft.AspNetCore.Mvc.Core
    • Microsoft.AspNetCore.Mvc.Formatters.Json
    • Microsoft.AspNetCore.Mvc.NewtonsoftJson
    • Microsoft.AspNetCore.Mvc.Testing
    • Microsoft.Azure.Cosmos
    • Microsoft.CodeAnalysis.CSharp.Scripting
    • Microsoft.CSharp
    • Microsoft.Extensions.Configuration
    • Microsoft.Extensions.Configuration.Json
    • Microsoft.Extensions.Configuration.UserSecrets
    • Microsoft.Extensions.DependencyInjection
    • Microsoft.IdentityModel.Protocols.OpenIdConnect
    • Microsoft.IdentityModel.Tokens
    • Microsoft.NET.Test.Sdk
    • MSTest.TestAdapter
    • MSTest.TestFramework
    • NAudio
    • Newtonsoft.Json
    • NuGet.Packaging
    • NunitXml.TestLogger
    • ReportGenerator
    • SlackAPI
    • System.Drawing.Common
    • System.IdentityModel.Tokens.Jwt
    • System.IO.Pipelines
    • System.Net.Security
    • System.Text.Encodings.Web
    • xunit.runner.visualstudio
    • XunitXml.TestLogger

Testing

The following image shows the unit tests working after the updates.
image

@JhontSouth JhontSouth requested a review from sw-joelmut July 25, 2024 14:30
@JhontSouth JhontSouth changed the title bump: Update old packages fix: [#6825]Update old packages Jul 25, 2024
sw-joelmut
sw-joelmut requested changes Jul 25, 2024
View reviewed changes
....Bot.Builder.Adapters.Slack.Tests/Microsoft - Backup.Bot.Builder.Adapters.Slack.Tests.csproj Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this file doesnt go right?, it says Backup...

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all the Backup files

...ot.Builder.Adapters.Twilio.Tests/Microsoft - Backup.Bot.Builder.Adapters.Twilio.Tests.csproj Outdated Show resolved Hide resolved
....Bot.Builder.Adapters.Webex.Tests/Microsoft - Backup.Bot.Builder.Adapters.Webex.Tests.csproj Outdated Show resolved Hide resolved
...eExpressions.Core.AOT.Tests/Microsoft - Backup.Bot.AdaptiveExpressions.Core.AOT.Tests.csproj Outdated Show resolved Hide resolved
....AdaptiveExpressions.Core.Tests/Microsoft - Backup.Bot.AdaptiveExpressions.Core.Tests.csproj Outdated Show resolved Hide resolved
tests/Microsoft.Bot.Builder.AI.LUIS.Tests/Microsoft - Backup.Bot.Builder.AI.Luis.Tests.csproj Outdated Show resolved Hide resolved
...ot.Builder.AI.Orchestrator.Tests/Microsoft - Backup.Bot.Builder.AI.Orchestrator.Tests.csproj Outdated
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, check all Backup. files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed all the Backup files

@JhontSouth
Copy link
Author

Promoted /6830

@JhontSouth JhontSouth closed this Jul 31, 2024
@JhontSouth JhontSouth deleted the southworks/update/old-packages branch July 31, 2024 14:50
@sw-joelmut sw-joelmut restored the southworks/update/old-packages branch July 31, 2024 15:37
@sw-joelmut sw-joelmut deleted the southworks/update/old-packages branch July 31, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sw-joelmut sw-joelmut sw-joelmut approved these changes

Assignees
No one assigned
Labels
Automation: No parity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JhontSouth @sw-joelmut