[#6768] CosmosDBKeyEscape.TruncateKeyIfNeeded return different value after compiled #587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sw-joelmut
approved these changes
Oct 21, 2024
JhontSouth
approved these changes
Oct 21, 2024
|
/promoted 6860 |
ceciliaavila
deleted the
southworks/update/replace-get-hash-code-method
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # 6768
#minor
Description
This PR implements a custom GetHashCode method to return the same hash code even on different bots' runs. This code is used in CosmosDBKeyEscape to truncate keys that are longer than 255 characters.
Specific Changes
GetDeterministicHashCodemethod in the CosmosDBKeyEscape class to replace the call to String.GetHashCode.Long_Key_Should_Be_Truncatedunit test to use the new method and verify its result.Testing
These images compare the hash codes returned by the GetHashCode and GetDeterministicHashCode methods in two different bot runs.
