Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cleanup race condition between AWS architectures #76

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

peterdeme
Copy link
Collaborator

@peterdeme peterdeme commented Jan 20, 2025

Description of the change

This PR fixes the issue where both x64 and arm64 architectures are trying to deregister old AMIs at the same time. One of them ends up failing.

Type of change

  • Bug fix (non-breaking change that fixes an issue);
  • New feature (non-breaking change that adds functionality);
  • Breaking change (fix or feature that would cause existing functionality to not work as expected);
  • Documentation (a documentation or example fix not affecting the infrastructure managed by this module);

Checklists

Development

  • All necessary variables have been defined, with defaults if applicable;
  • The HCL code is formatted;
  • An AMI has been created in some AWS account, and the AMI is working as expected;

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached;
  • This pull request is no longer marked as "draft";
  • Reviewers have been assigned;
  • Changes have been reviewed by at least one other engineer;

@peterdeme peterdeme marked this pull request as ready for review January 20, 2025 10:09
@peterdeme peterdeme requested a review from a team as a code owner January 20, 2025 10:09
@peterdeme peterdeme requested review from eliecharra and a team January 20, 2025 10:09
eliecharra
eliecharra previously approved these changes Jan 20, 2025
Copy link
Member

@eliecharra eliecharra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🙏🏻

Just left one comment in case there is a better way to do that, packer noob talking here 🙇🏻

aws.pkr.hcl Outdated Show resolved Hide resolved
Signed-off-by: peterdeme <snypox@gmail.com>
@peterdeme peterdeme merged commit 4676277 into main Jan 20, 2025
3 checks passed
@peterdeme peterdeme deleted the fix-race-condition branch January 20, 2025 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants