Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc(CU-869756wtw): add a section about workerpool controller metrics #707

Merged
merged 3 commits into from
Jan 17, 2025

Conversation

eliecharra
Copy link
Member

@eliecharra eliecharra commented Jan 15, 2025

Description of the change

This adds a section to explain how to use the workerpool controller metrics.

I also make the warning a bit more visible in the Helm installation section, and fixed indentation for the promex exporter.

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

@eliecharra eliecharra force-pushed the doc/k8s_workerpool_controller_metrics branch from 4a5a3e2 to b4de253 Compare January 15, 2025 10:45
@eliecharra eliecharra changed the title doc: add a section about workerpool controller metrics doc(CU-869756wtw): add a section about workerpool controller metrics Jan 15, 2025
@eliecharra eliecharra marked this pull request as ready for review January 15, 2025 12:59
@eliecharra eliecharra force-pushed the doc/k8s_workerpool_controller_metrics branch from a6dfc6e to c371e23 Compare January 15, 2025 13:00
@adamconnelly adamconnelly temporarily deployed to doc/k8s_workerpool_controller_metrics - spacelift-user-documentation PR #707 January 15, 2025 13:00 — with Render Destroyed
@eliecharra eliecharra requested a review from peterdeme January 16, 2025 14:11
@eliecharra eliecharra requested a review from a team January 16, 2025 14:34
@eliecharra eliecharra merged commit 9964743 into main Jan 17, 2025
1 check passed
@eliecharra eliecharra deleted the doc/k8s_workerpool_controller_metrics branch January 17, 2025 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants