Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notes to change the slack integration and remove it #708

Merged
merged 3 commits into from
Jan 20, 2025
Merged

Conversation

Daniellem97
Copy link
Contributor

@Daniellem97 Daniellem97 commented Jan 15, 2025

Description of the change

Checklist

Please make sure that the proposed change checks all the boxes below before requesting a review:

  • I have reviewed the guidelines for contributing to this repository.
  • The preview looks fine.
  • The tests pass.
  • The commit history is clean and meaningful.
  • The pull request is opened against the main branch.
  • The pull request is no longer marked as a draft.
  • You agree to license your contribution under the MIT license to Spacelift (not required for Spacelift employees).
  • You have updated the navigation files correctly:
    • No new pages have been added, or;
    • Only nav.yaml has been updated because the changes only apply to SaaS, or;
    • Only nav.self-hosted.yaml has been updated because the changes only apply to Self-Hosted, or;
    • Both nav.yaml and nav.self-hosted.yaml have been updated.

If the proposed change is ready to be merged, please request a review from @spacelift-io/solutions-engineering. Someone will review and merge the pull request.

Spacelift employees should request reviews from the relevant engineers and are allowed to merge pull requests after they got at least one approval.

Thank you for your contribution! 🙇

eminalemdar
eminalemdar previously approved these changes Jan 17, 2025
@peterdeme
Copy link
Contributor

@adamconnelly does it look good to you?

Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just left a couple of minor suggestions on wording.

docs/product/administration/slack-integration-setup.md Outdated Show resolved Hide resolved
docs/product/administration/slack-integration-setup.md Outdated Show resolved Hide resolved
Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>
@adamconnelly adamconnelly temporarily deployed to slackupdates - spacelift-user-documentation PR #708 January 20, 2025 15:58 — with Render Destroyed
Co-authored-by: Adam Connelly <adam.rpconnelly@gmail.com>
@adamconnelly adamconnelly temporarily deployed to slackupdates - spacelift-user-documentation PR #708 January 20, 2025 15:58 — with Render Destroyed
Copy link
Contributor

@adamconnelly adamconnelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a question, but it's not a blocker for this PR being merged.

@Daniellem97 Daniellem97 enabled auto-merge (rebase) January 20, 2025 16:18
@Daniellem97 Daniellem97 merged commit 472c8fb into main Jan 20, 2025
1 check passed
@Daniellem97 Daniellem97 deleted the slackupdates branch January 20, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants