Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node-split: Add check if ATXv2 is live already for malsync #6717

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

fasmat
Copy link
Member

@fasmat fasmat commented Feb 11, 2025

Motivation

This ports #6715 to the node-split build

Description

No other changes

Test Plan

n/a

TODO

  • Explain motivation or link existing issue(s)
  • Test changes and document test plan
  • Update documentation as needed
  • Update changelog as needed

## Motivation

This adds a check to malfeasance sync to not sync with other peers before the first ATXv2 epoch.
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

Attention: Patch coverage is 97.29730% with 1 line in your changes missing coverage. Please review.

Project coverage is 77.1%. Comparing base (a21cfea) to head (d211d6f).
Report is 5 commits behind head on node-split-poc.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
syncer/malsync/syncer.go 91.6% 1 Missing ⚠️
Additional details and impacted files
@@              Coverage Diff               @@
##           node-split-poc   #6717   +/-   ##
==============================================
  Coverage            77.1%   77.1%           
==============================================
  Files                 387     389    +2     
  Lines               54129   54201   +72     
==============================================
+ Hits                41744   41843   +99     
+ Misses               9889    9865   -24     
+ Partials             2496    2493    -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fasmat fasmat merged commit 3f19d0d into node-split-poc Feb 11, 2025
16 checks passed
@fasmat fasmat deleted the backport-6715 branch February 11, 2025 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants