BUGFIX fix issue with with_units causing a loss of array entries
#563
+57
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #563 +/- ##
==========================================
- Coverage 86.04% 86.02% -0.02%
==========================================
Files 27 27
Lines 4048 4050 +2
==========================================
+ Hits 3483 3484 +1
- Misses 565 566 +1 ☔ View full report in Codecov by Sentry. |
|
Would it be possible to fix LGTM |
nden
requested changes
Feb 14, 2025
Just fixed this. |
WilliamJamieson
force-pushed
the
bugfix/lost_array_values
branch
from
be43dfe to
cb852c0
Compare
WilliamJamieson
force-pushed
the
bugfix/lost_array_values
branch
from
cb852c0 to
13cc195
Compare
This was largely an issue of the zip(strict=False) causing missed entries. I made this strict=True
…trip to directly on the bounding box
WilliamJamieson
force-pushed
the
bugfix/lost_array_values
branch
from
13cc195 to
fce7ed1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #559
The issue is that
with_unitswas accidentally loosing elements of an array for "vector" values. That is if your in the 1D case and your shape is(n,)instead of(1, n)the only the first entry of the vector was returned in the "high-level" object.The issue was due to a
zip(arrays, units, strict=False)loosing things because there were morearraysentries thanunitsentries. The issue is that for the "vector" the zip will iterate over each of the entries in the vector, where as a 1D array would just iterate once yielding the entire "vector" entry.The solution is twofold:
gwcs.naxes==1before the zip and wrapping the "vector" into a tuple.