Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test with latest supported Python version and drop Python 3.10 #569

Merged
merged 2 commits into from
Feb 26, 2025
Merged

test with latest supported Python version and drop Python 3.10 #569

merged 2 commits into from
Feb 26, 2025

Conversation

zacharyburnett
Copy link
Collaborator

@zacharyburnett zacharyburnett commented Feb 24, 2025 •
edited
Loading

@zacharyburnett zacharyburnett self-assigned this Feb 24, 2025
@codecov Codecov
Copy link

codecov bot commented Feb 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.04%. Comparing base (f391f14) to head (c6ee47f).
Report is 15 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #569      +/-   ##
==========================================
+ Coverage   85.96%   86.04%   +0.07%     
==========================================
  Files          27       27              
  Lines        4025     4048      +23     
==========================================
+ Hits         3460     3483      +23     
  Misses        565      565

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zacharyburnett zacharyburnett marked this pull request as ready for review February 24, 2025 19:38
@zacharyburnett zacharyburnett requested a review from a team as a code owner February 24, 2025 19:38
@zacharyburnett zacharyburnett marked this pull request as draft February 24, 2025 20:01
@zacharyburnett zacharyburnett marked this pull request as ready for review February 25, 2025 14:26
WilliamJamieson
WilliamJamieson requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you drop support for Python 3.10 while your at it?

Also what caused all the pyproject.toml changes?

WilliamJamieson
WilliamJamieson requested changes Feb 25, 2025
View reviewed changes
Copy link
Collaborator

@WilliamJamieson WilliamJamieson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Please add a change log noting the python version change.

@zacharyburnett zacharyburnett changed the title test with latest supported Python version test with latest supported Python version and drop Python 3.10 Feb 25, 2025
@WilliamJamieson WilliamJamieson merged commit fa6cced into spacetelescope:master Feb 26, 2025
25 of 26 checks passed
@WilliamJamieson WilliamJamieson mentioned this pull request Feb 26, 2025
Closed
@zacharyburnett zacharyburnett deleted the py313 branch February 26, 2025 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WilliamJamieson WilliamJamieson WilliamJamieson approved these changes

Assignees

@zacharyburnett zacharyburnett

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zacharyburnett @WilliamJamieson