3083 bugs terraform google gcp cloud native drupal resources module

[Stevesibilia]

User description

As detailed here: hashicorp/terraform#30633 (comment)

---

PR Type

Bug fix, Enhancement

---

Description

• Enhanced security by removing the use of templatefile function, which could potentially expose sensitive information in the Terraform state.
• Improved the local-exec provisioner configuration by using the environment block to pass variables to the script, reducing the risk of secret exposure.
• Simplified the code by directly executing the script instead of using a template, making it easier to maintain and understand.
• Maintained the same functionality while improving the overall structure and security of the SQL user provisioning process.

---

Changes walkthrough 📝

	Relevant files
Enhancement	main.tf Improve security and simplify SQL user provisioning            main.tf Replaced templatefile function with direct script execution Moved variables to environment block for better security Simplified the local-exec provisioner configuration +14/-16

---

💡 PR-Agent usage:
Comment /help on the PR to get a list of all available PR-Agent tools and their descriptions

[sparkfabrik-ai-bot]

PR Reviewer Guide 🔍

⏱️ Estimated effort to review: 2 🔵🔵⚪⚪⚪

🧪 No relevant tests

🔒 No security concerns identified

⚡ Key issues to review Code Improvement The PR replaces the use of templatefile function with direct script execution and environment variables, which enhances security and simplifies the code.

[sparkfabrik-ai-bot]

PR Code Suggestions ✨

Category	Suggestion	Score
Enhancement	Use a more specific shell interpreter for local-exec provisioner Consider using a more specific interpreter like bash instead of /bin/sh for better script compatibility and features. main.tf [76-77] interpreter = [ - "/bin/sh", "-c" + "/bin/bash", "-c" ] Suggestion importance[1-10]: 3 Why: While using bash instead of sh could provide more features, it's a minor improvement and not crucial. The current implementation with sh is likely sufficient for most use cases.	3