Updates in Pattern Distortion Pipeline #276
Conversation
ss756
added
bug
| [True, False], | ||
| ) # randomly select to apply Perlin Noise on top of the Tessellation | ||
| else: | ||
| self.perlin = False |
There was a problem hiding this comment.
I think here should be self.perlin = self.noise_type because if user set True on perlin, we need to get it here.
There was a problem hiding this comment.
Hi @kwcckw, the only option we are giving the user is to select the noise_type. It will either be None or "random" for now. If it is random, then Perlin Noise may or may not be added. It is None or any other value, Perlin Noise is not added.
Explicitly the user cannot select True for Noise_type. What I would suggest is that the user selects noise_type = "perlin" so that perlin noise is integrated. Is this ok ?
There was a problem hiding this comment.
Yes, this should work, so you need to mention this in the class descriptions too.
There was a problem hiding this comment.
Yes @kwcckw i will add this to the class description
| if self.noise_type == "random": | ||
| self.perlin = random.choice([True, False]) | ||
| else: | ||
| self.perlin = False |
There was a problem hiding this comment.
This is similar with the issue i mentioned above.
resolves #242
This PR contains updates for Pattern Distortion pipeline, such that it can handle gray-scale images as well. The parameters of each function is randomized in call() instead of init() function, so that it has different values in each run.
Made changes to the docs.