Skip to content
This repository has been archived by the owner on Nov 21, 2018. It is now read-only.

Get example to work #2

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

intellix
Copy link

@intellix intellix commented Aug 16, 2017

I noticed that the demo wasn't actually using the packages and wanted to see it working.

test doesn't seem to support --preserve-symlinks at the moment, which will be needed for this to work.

I tried adding the sh symlink.sh as a postinstall script inside demo package.json but it didn't get run :( Related issue: yarnpkg/yarn#3911

@dherges
Copy link
Contributor

dherges commented Aug 24, 2017

Hi @intellix,

excuse my late response. This is a side project which I don't actively work on. For the monorepo approach at my work, we do NOT use yarn workspaces but rather a custom "by-hand" solution. We still find w/ Angular CLI that it's best to have .angular-cli.json at the monorepo root.

@intellix
Copy link
Author

intellix commented Sep 1, 2017

Sure, just testing a variety of options. I tried TS 2.5 before but it didn't really work. I wonder if this'll help: angular/angular-cli#7568

@dherges
Copy link
Contributor

dherges commented Sep 1, 2017

@intellix Thanks! Will check it once released in new version of Angular CLI

@intellix
Copy link
Author

intellix commented Sep 5, 2017

Filipe created a PR that fixes the requirement for @angular/core so the symlink isn't required anymore: angular/angular-cli#7601
Also fix for ng test missing the preserve: angular/angular-cli#7598

@dherges
Copy link
Contributor

dherges commented Sep 6, 2017

Ok, cool!

Wait and try again with cli@1.4.0-rc.3 or later

@intellix
Copy link
Author

intellix commented Sep 9, 2017

Another interesting comment in regards to types across projects: microsoft/TypeScript#6496 (comment)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants