Adding Uganda Holidays #11
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lidays Eid al-Fitr and Eid al-Adha
* feature: add bolivian holidays * test: add bolivia test * test snap * fixed typo and phpstan * calculate correct easter date * Fix styling --------- Co-authored-by: rats4final <rats4final@gmail.con> Co-authored-by: rats4final <rats4final@users.noreply.github.com>
…lidays Eid al-Fitr and Eid al-Adha
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes Introduced:
Introduction of a new Uganda class to handle accurate calculations for Uganda public holidays
Overview:
This pull request introduces a dedicated Uganda class within the Spatie\Holidays\Countries namespace. The class is designed to handle precise calculations for public holidays in Uganda. This addition ensures that developers have access to accurate dates for both fixed and variable holidays specific to Uganda.
Correlation Check:
Reviewers can confirm the correlation of the generated holidays by comparing them with the official holidays listed on here
Point to Note
This class includes computations for the Islamic calendar holidays Eid al-Fitr and Eid al-Adha which I would like to refactor into the
Countryclass so that its useable by other countries which observe the two holidays