rust updates #6
Merged
rust updates #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Options removed from build.rs are set by feature flags as of 0.7.0. Reference: https://docs.rs/crate/built/0.7.5/source/CHANGELOG.md
crates.io no longer displays these. Additionally the URLs were out of date.
This does not make sense as a feature because the extension does not work without it.
|
Hi @newAM, glad this is useful and thanks for making this PR! I'll have a look at the build failures but it's quite likely the CI is very outdated 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for this extension!
I was having some trouble installing the extension because Cargo.lock was getting updated somehow, and
builtcould not parseversion = 4Cargo.lock files. Updatingbuiltfixed this.I updated pyo3 as well since I was already updating things. Details are in the individual commits. I can split the commits into separate pull-requests if desired.