Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rl/add height weight #109

Merged
merged 38 commits into from
Dec 10, 2021

Conversation

renelabounek
Copy link
Contributor

@jcohenadad and @alexfoias, I have updated participants.tsv file about available height and weight records and submit this PR.

We only miss records from tehran, which might come after New Year, and 2 of 6 records from perform.

tokyo* submissions has uploaded data of 7 same subjects acquired at 3 different scanners. I am not sure, if this important fact is recorded somewhere.

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will conflict with #97.

I suggest we first merge this branch, and then #97.

Copy link
Member

@jcohenadad jcohenadad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this @renelabounek

@alexfoias
Copy link
Contributor

alexfoias commented Dec 3, 2021

@renelabounek thank you for your help. Regarding the tokyo* submissions, we are talking of the same subjects, but on different sites. That was my understanding, @jcohenadad can confirm.

@jcohenadad jcohenadad mentioned this pull request Dec 3, 2021
@jcohenadad
Copy link
Member

tokyo* submissions has uploaded data of 7 same subjects acquired at 3 different scanners. I am not sure, if this important fact is recorded somewhere.

not properly recorded and this is indeed a problem-- related to #102

@renelabounek
Copy link
Contributor Author

Is there some pending reason why data have not been merged to the master version yet? Or is it stucked again on some robot process from fork into master?

@jcohenadad jcohenadad merged commit 20b191e into spine-generic:master Dec 10, 2021
@jcohenadad
Copy link
Member

jcohenadad commented Dec 10, 2021

Is there some pending reason why data have not been merged to the master version yet? Or is it stucked again on some robot process from fork into master?

The PR was not merged 😉

Now fixed

@renelabounek renelabounek deleted the rl/add-height-weight branch January 4, 2022 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants