factors-executor: Add ComponentLoader::load_instance_pre #3036
+24
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rylev
approved these changes
Mar 4, 2025
crates/factors-executor/src/lib.rs
Outdated
| @@ -102,13 +101,23 @@ where | |||
|
|
|||
| /// A ComponentLoader is responsible for loading Wasmtime [`Component`]s. | |||
| #[async_trait] | |||
| pub trait ComponentLoader { | |||
| pub trait ComponentLoader: Sync { | |||
There was a problem hiding this comment.
The honest answer is "because the compiler says so". I'm pretty sure its some quirk of async_trait.
There was a problem hiding this comment.
Specifically, up at the load_instance_pre call site I get:
error[E0277]: `impl ComponentLoader` cannot be shared between threads safely
--> crates/factors-executor/src/lib.rs:71:18
|
71 | .load_instance_pre(&self.core_engine, &component)
| ^^^^^^^^^^^^^^^^^ `impl ComponentLoader` cannot be shared between threads safely
|
note: required by a bound in `ComponentLoader::load_instance_pre`
--> crates/factors-executor/src/lib.rs:103:1
|
103 | #[async_trait]
| ^^^^^^^^^^^^^^ required by this bound in `ComponentLoader::load_instance_pre`
...
113 | async fn load_instance_pre<T>(
| ----------------- required by a bound in this associated function
= note: this error originates in the attribute macro `async_trait` (in Nightly builds, run with -Z macro-backtrace for more info)
help: consider further restricting this bound
|
55 | component_loader: &impl ComponentLoader + std::marker::Sync,
| +++++++++++++++++++
lann
force-pushed
the
load-instance-pre
branch
2 times, most recently
from
90c7a5d to
897c102
Compare
This lets embedders customize more of the component loading process. Signed-off-by: Lann Martin <lann.martin@fermyon.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This lets embedders customize more of the component loading process.