Merge pull request #374 from andreibondarev/remove_legacy_code

Remove legacy methods
splitrb · Apr 25, 2016 · a82c771 · a82c771
2 parents a58748c + 4dd2c30
commit a82c771
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/split/encapsulated_helper.rb b/lib/split/encapsulated_helper.rb
@@ -2,9 +2,9 @@
 # Split's helper exposes all kinds of methods we don't want to
 # mix into our model classes.
 #
-# This module exposes only two methods
-#  - ab_test and
-#  - ab_test_finished
+# This module exposes only two methods:
+#  - ab_test()
+#  - finished()
 # that can safely be mixed into any class.
 #
 # Passes the instance of the class that it's mixed into to the
@@ -44,6 +44,7 @@ def ab_test(*arguments)
     end
 
     def ab_test_finished(*arguments)
+      warn 'DEPRECATION WARNING: ab_test_finished is deprecated and will be removed from Split 1.5.0'
       split_context_shim.finished *arguments
     end
 

diff --git a/lib/split/helper.rb b/lib/split/helper.rb
@@ -87,6 +87,7 @@ def split_generically_disabled?
     end
 
     def begin_experiment(experiment, alternative_name = nil)
+      warn 'DEPRECATION WARNING: begin_experiment is deprecated and will be removed from Split 1.5.0'
       alternative_name ||= experiment.control.name
       ab_user[experiment.key] = alternative_name
       alternative_name