-
Notifications
You must be signed in to change notification settings - Fork 737
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Raise the minimum supported version of AsciidoctorJ to 3.0
Closes gh-957
- Loading branch information
1 parent
85ebc4e
commit 0b103fd
Showing
9 changed files
with
118 additions
and
37 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
...src/main/java/org/springframework/restdocs/asciidoctor/DefaultAttributesPreprocessor.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
/* | ||
* Copyright 2014-2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.restdocs.asciidoctor; | ||
|
||
import org.asciidoctor.ast.Document; | ||
import org.asciidoctor.extension.Preprocessor; | ||
import org.asciidoctor.extension.PreprocessorReader; | ||
import org.asciidoctor.extension.Reader; | ||
|
||
/** | ||
* {@link Preprocessor} that sets defaults for REST Docs-related {@link Document} | ||
* attributes. | ||
* | ||
* @author Andy Wilkinson | ||
*/ | ||
final class DefaultAttributesPreprocessor extends Preprocessor { | ||
|
||
private final SnippetsDirectoryResolver snippetsDirectoryResolver = new SnippetsDirectoryResolver(); | ||
|
||
@Override | ||
public Reader process(Document document, PreprocessorReader reader) { | ||
document.setAttribute("snippets", this.snippetsDirectoryResolver.getSnippetsDirectory(document.getAttributes()), | ||
false); | ||
return reader; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 changes: 0 additions & 14 deletions
14
spring-restdocs-asciidoctor/src/main/resources/extensions/default_attributes.rb
This file was deleted.
Oops, something went wrong.
67 changes: 67 additions & 0 deletions
67
...est/java/org/springframework/restdocs/asciidoctor/DefaultAttributesPreprocessorTests.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
/* | ||
* Copyright 2014-2025 the original author or authors. | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* https://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.springframework.restdocs.asciidoctor; | ||
|
||
import java.io.File; | ||
|
||
import org.asciidoctor.Asciidoctor; | ||
import org.asciidoctor.Attributes; | ||
import org.asciidoctor.Options; | ||
import org.junit.Test; | ||
|
||
import static org.assertj.core.api.Assertions.assertThat; | ||
|
||
/** | ||
* Tests for {@link DefaultAttributesPreprocessor}. | ||
* | ||
* @author Andy Wilkinson | ||
*/ | ||
public class DefaultAttributesPreprocessorTests { | ||
|
||
@Test | ||
public void snippetsAttributeIsSet() { | ||
String converted = createAsciidoctor().convert("{snippets}", createOptions("projectdir=../../..")); | ||
assertThat(converted).contains("build" + File.separatorChar + "generated-snippets"); | ||
} | ||
|
||
@Test | ||
public void snippetsAttributeFromConvertArgumentIsNotOverridden() { | ||
String converted = createAsciidoctor().convert("{snippets}", | ||
createOptions("snippets=custom projectdir=../../..")); | ||
assertThat(converted).contains("custom"); | ||
} | ||
|
||
@Test | ||
public void snippetsAttributeFromDocumentPreambleIsNotOverridden() { | ||
String converted = createAsciidoctor().convert(":snippets: custom\n{snippets}", | ||
createOptions("projectdir=../../..")); | ||
assertThat(converted).contains("custom"); | ||
} | ||
|
||
private Options createOptions(String attributes) { | ||
Options options = Options.builder().build(); | ||
options.setAttributes(Attributes.builder().arguments(attributes).build()); | ||
return options; | ||
} | ||
|
||
private Asciidoctor createAsciidoctor() { | ||
Asciidoctor asciidoctor = Asciidoctor.Factory.create(); | ||
asciidoctor.javaExtensionRegistry().preprocessor(new DefaultAttributesPreprocessor()); | ||
return asciidoctor; | ||
} | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters