Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New API: extraTypeAnnotations #2794

Closed
wants to merge 3 commits into from

Conversation

swankjesse
Copy link
Collaborator

The goal of this new API is to allow users to specify extra annotations that'll apply to the Wire-generated classes. This is specifically useful for the @immutable annotation offered by Jetpack Compose, and could be useful for other annotations.

The goal of this new API is to allow users to specify
extra annotations that'll apply to the Wire-generated
classes. This is specifically useful for the @immutable
annotation offered by Jetpack Compose, and could be useful
for other annotations.
@JakeWharton
Copy link
Collaborator

The Compose compiler allows you to provide a list of external types that are stable. So if one provided Wire's Message I think you wouldn't need this feature (Compose will traverse the hierarchy of a type). Unless there are actually other use cases in mind.

@oldergod
Copy link
Member

oldergod commented Jan 24, 2024

@oldergod
Copy link
Member

Other usecase would be #807

@swankjesse
Copy link
Collaborator Author

I’m going to shelve this for now because I believe the Compose configuration file can solve my immediate problem.

I think there’s potentially something useful for Wire to do to hint to Compose about what’s immutable.

@swankjesse swankjesse closed this Jan 24, 2024
@oldergod oldergod deleted the jwilson.0123.extra_type_annotations branch January 24, 2024 16:11
@autonomousapps
Copy link
Contributor

Other usecase would be #807

JaCoCo will automatically excluded generated files from code coverage reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants