Move fs interface to separate package and simplify #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The filesystem abstraction (formerly
ocfl.FS) is moved to a separate package, in thefsdirectory.The new FS interface only includes a single method,
OpenFile(). There is also a new interfaceDirEntriesFSfor reading directories. The idea is that directory support often isn't needed. You can use an OCFL object without listing the contents of a directory, so the backends shouldn't be required to implement directory listing. This enables simple backends for reading objects (e.g., over plain http).I also simplified some of the file iteration logic, removing the dedicated iterator types.