Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix export template when using dummy links #2483

Merged
merged 1 commit into from
Feb 21, 2025
Merged

Fix export template when using dummy links #2483

merged 1 commit into from
Feb 21, 2025

Conversation

hellt
Copy link
Member

@hellt hellt commented Feb 21, 2025

fix #2480
when dummy links are used, the endpoint section in the export template will now contain only "a" side, with the peer set to dummy:

  "links": [
    {
      "a": {
        "node": "l1",
        "interface": "eth1",
        "mac": "aa:c1:ab:97:93:32",
        "peer": "dummy"
      }
    }
  ]
}

@hellt hellt merged commit 1c9c561 into main Feb 21, 2025
66 of 67 checks passed
@hellt hellt deleted the export-dummy branch February 21, 2025 10:41
Copy link

codecov bot commented Feb 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.43%. Comparing base (43367b9) to head (9ff42b3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
clab/export.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2483      +/-   ##
==========================================
- Coverage   52.52%   52.43%   -0.10%     
==========================================
  Files         172      172              
  Lines       17692    17692              
==========================================
- Hits         9292     9276      -16     
- Misses       7422     7439      +17     
+ Partials      978      977       -1     
Files with missing lines Coverage Δ
clab/export.go 40.57% <0.00%> (-31.89%) ⬇️

... and 1 file with indirect coverage changes

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

using dummy links (or links with a single endpoint) break export template logic
1 participant